OP-1199 Small improvements #2107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbmalkovsky
reviewed
Jan 9, 2025
dbmalkovsky
reviewed
Jan 9, 2025
dbmalkovsky
reviewed
Jan 9, 2025
dbmalkovsky
reviewed
Jan 9, 2025
src/main/java/org/isf/medicalinventory/gui/InventoryBrowser.java
Outdated
Show resolved
Hide resolved
dbmalkovsky
reviewed
Jan 9, 2025
src/main/java/org/isf/medicalinventory/gui/InventoryBrowser.java
Outdated
Show resolved
Hide resolved
dbmalkovsky
reviewed
Jan 9, 2025
|
Generally it looks OK but the code (especially the original code) has many code implementation issues. I only marked those that I could see in the diff from this PR. Remind me when this gets merged to go back and really go other the code constructs and newer language level options. |
should be ok now, please check |
mwithi
merged commit 9bf7b3d
into
informatici:OP-1199-Main-Store-Inventory
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small improvements for OP-1199.