OP-749 | To extend laboratory filter panel with search by patient #2104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atory-filter-panel-with-search-by-patient-id
dbmalkovsky
reviewed
Dec 6, 2024
| } else { | ||
| try { | ||
| pat = patManager.getPatientById(Integer.parseInt(patid)); | ||
| exists = pat == null ? false : true; |
There was a problem hiding this comment.
Suggested change
| exists = pat == null ? false : true; | |
| exists = pat != null; |
This is much simpler and does the same thing. The variable exists appears to be used only one in line 532. Why not just test the variable pat there? And if there is an exception (catch block at line 527) the variable exists will not be reset and will use the assigned value from line 518 which is true. So, if there is an exception then line 533 will be executed which given that pat is null will most likely cause other errors. It looks like some rethinking of this logic is in order.
…atory-filter-panel-with-search-by-patient-id
…arch-by-patient-id' of https://github.com/ra247362/openhospital-gui into OP-749-oh-gui-to-extend-laboratory-filter-panel-with-search-by-patient-id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See OH-749
We added a text field in the laboratory section to allow for search by code, as described in the issue. We added error messages when invalid codes were added. The implemented behavior follows the one described in the issue, with the ENTER key being used to search only by code and the SEARCH button used to search by code and date.
Changes were made only in "LabBrowser.java" and the bundled language file "language_en.properties".