OP-1341 Enable Medical Type for Soft Deletion #2092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dbmalkovsky
reviewed
Nov 21, 2024
dbmalkovsky
reviewed
Nov 21, 2024
|
@dbmalkovsky , Can someone of you confirm about the text ? |
Since we have already fields like XXX_ACTIVE in the DB (for future uses), I would use "Deleted" (like the new field) to avoid confusion. |
|
@mwithi Refactored active to deleted text and corresponding logic. Hoping to get PR merged 🤞 |
mwithi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See OP-1341.
Paired with informatici/openhospital-core#1458.