Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OP-1304 | Enhance product selections in edit inventory #2091

Merged
merged 34 commits into from
Dec 19, 2024

Conversation

ArnaudFofou
Copy link
Contributor

@ArnaudFofou ArnaudFofou commented Nov 21, 2024

See OP-1304.

Copy link
Member

@mwithi mwithi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although the feature is doing what expected, there is room of code improvements, please read the comments

@dbmalkovsky
Copy link
Collaborator

There needs to be a review of the whole file of InventoryEdit not just the recent changes. For example, there are other occurrences that should be using isEmtpy(); there are allocations where <> should be used instead of the type; there are occurrences where Boxed types (specially Integer) is being compared with == instead of equals(), etc.

@mwithi mwithi merged commit 6dcec23 into informatici:OP-1199-Main-Store-Inventory Dec 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants