OP-1043 | Implement soft deletion

[SteveGT96]

See OP-1043

[mwithi]

LGTM. Thanks a lot!

found more issues

[mwithi]

Although when editing a soft-deleted user or group it blocks the operation because the record "is already marked as deleted", I think we can live with it because why one should edit other fields on an already soft-deleted record? If really needed one can temporarly remove the "deleted" check, change the required fields and mark it again as deleted afterward.

Wdyt?

[SteveGT96]

Although when editing a soft-deleted user or group it blocks the operation because the record "is already marked as deleted", I think we can live with it because why one should edit other fields on an already soft-deleted record? If really needed one can temporarly remove the "deleted" check, change the required fields and mark it again as deleted afterward.

Wdyt?

My Opinion at the beginning is that the edit boutton shoudn't be enabled after soft deletion. Instead, we should have just added a "Restore" button that is only shown when the selected item is soft deleted(by clicking on it, we restore the item and therefore make the item editable again).

[SteveGT96]

@mwithi, the pipeline is broken.

[mwithi]

@mwithi, the pipeline is broken.

it's fine, it's because it is taking informatici core instead of your core, IDKW.... on a next commit from your should be ok

[mwithi]

My Opinion at the beginning is that the edit boutton shoudn't be enabled after soft deletion. Instead, we should have just added a "Restore" button that is only shown when the selected item is soft deleted(by clicking on it, we restore the item and therefore make the item editable again).

If you want to implement like that is ok also, but in GUI we never had something like "Restore" and we mostly stick to "Edit" term for any operation... we will update the DOC though, so well explained everything is possible.

[SteveGT96]

My Opinion at the beginning is that the edit boutton shoudn't be enabled after soft deletion. Instead, we should have just added a "Restore" button that is only shown when the selected item is soft deleted(by clicking on it, we restore the item and therefore make the item editable again).

If you want to implement like that is ok also, but in GUI we never had something like "Restore" and we mostly stick to "Edit" term for any operation... we will update the DOC though, so well explained everything is possible.

We could do that later in an enhancement task.

[mwithi]

I think checks are failing because GUI and CORE are not equally aligned with develop