-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OP-1339 Fix lots overlooking when they reach zero quantity #2074
Merged
mwithi
merged 13 commits into
develop
from
OP-1339-fix-lots-overlooking-when-they-reach-zero-quantity
Oct 30, 2024
Merged
OP-1339 Fix lots overlooking when they reach zero quantity #2074
mwithi
merged 13 commits into
develop
from
OP-1339-fix-lots-overlooking-when-they-reach-zero-quantity
Oct 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
going to fix build upon "push" events too... |
@dbmalkovsky now should be ok |
dbmalkovsky
reviewed
Oct 29, 2024
dbmalkovsky
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (given you ignore my suffix suggestion).
OP-1339-fix-lots-overlooking-when-they-reach-zero-quantity
ArnaudFofou
approved these changes
Oct 30, 2024
mwithi
deleted the
OP-1339-fix-lots-overlooking-when-they-reach-zero-quantity
branch
October 30, 2024 22:23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See OP-1339.
Paired with informatici/openhospital-core#1441.
Also add workflow refactoring