Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OP-1340 Force Lot's cost definition when LOTWITHCOST=yes and AUTOMATICLOT_IN=no #2066

Merged
merged 2 commits into from
Oct 15, 2024
Merged

OP-1340 Force Lot's cost definition when LOTWITHCOST=yes and AUTOMATICLOT_IN=no #2066

merged 2 commits into from
Oct 15, 2024

Conversation

mwithi
Copy link
Member

@mwithi mwithi commented Oct 14, 2024

@mwithi mwithi requested a review from dbmalkovsky October 14, 2024 13:27
dbmalkovsky
dbmalkovsky approved these changes Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@dbmalkovsky dbmalkovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; left a comment that can be ignored

@mwithi
Copy link
Member Author

mwithi commented Oct 15, 2024

LGTM; left a comment that can be ignored

Thanks! Which comment?

@mwithi mwithi requested a review from dbmalkovsky October 15, 2024 09:21
dbmalkovsky
dbmalkovsky reviewed Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@dbmalkovsky dbmalkovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mwithi mwithi merged commit dfde269 into develop Oct 15, 2024
0 of 2 checks passed
@mwithi mwithi deleted the OP-1340-fix-lots-without-costs-usage-when-switching-to-lotwitcost-yes branch October 15, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbmalkovsky dbmalkovsky dbmalkovsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mwithi @dbmalkovsky