Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: add missing @Override annotation #1459

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Chore: add missing @Override annotation #1459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .../org/isf/telemetry/envdatacollector/collectors/remote/geoiplookup/GeoIpLookupService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ public GeoIpLookupService(GeoIpInfoSettings geoIpInfoSettings) {
this.settings = geoIpInfoSettings;
}

@Override
public GeoIpLookup retrieveIpInfo() {
GeoIpLookupRemoteService httpClient = super.buildHttlClient(this.settings.retrieveBaseUrl(this.getServiceName()), GeoIpLookupRemoteService.class,
GeoIpLookupService.class);
Expand All @@ -50,6 +51,7 @@ public GeoIpLookup retrieveIpInfo() {
return result;
}

@Override
public String getServiceName() {
return SERVICE_NAME;
}
Expand Down
2 changes: 2 additions & 0 deletions src/main/java/org/isf/telemetry/envdatacollector/collectors/remote/ipapi/IpApiService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ public IpApiService(GeoIpInfoSettings geoIpInfoSettings) {
this.settings = geoIpInfoSettings;
}

@Override
public IpApi retrieveIpInfo() {
IpApiRemoteservice httpClient = buildHttlClient(this.settings.retrieveBaseUrl(this.getServiceName()), IpApiRemoteservice.class, IpApiService.class);
LOGGER.debug("IpApi request start");
Expand All @@ -49,6 +50,7 @@ public IpApi retrieveIpInfo() {
return result;
}

@Override
public String getServiceName() {
return SERVICE_NAME;
}
Expand Down