Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OP-1305 | Add confirm inventory method #1430

Closed
wants to merge 30 commits into from

Conversation

ArnaudFonzam
Copy link
Contributor

@ArnaudFonzam ArnaudFonzam commented Oct 4, 2024

See OP-1305.

Copy link
Collaborator

@dbmalkovsky dbmalkovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be multiple tests to validate the new method. I can't see approving this PR without it.

@mwithi mwithi dismissed dbmalkovsky’s stale review October 8, 2024 09:59

Tests added, testConfirmMedicalInventory is failing though

@ArnaudFofou
Copy link
Contributor

to be close. the new work is on #1436

@mwithi
Copy link
Member

mwithi commented Oct 22, 2024

Superseded by #1436

@mwithi mwithi closed this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants