New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OP-1351 | Change operation opeFor field to enum #1427

Merged

mwithi merged 13 commits into informatici:develop from SteveGT96:update/OP-1351-change-OP_FOR-field

Oct 7, 2024

Contributor

SteveGT96 commented Oct 3, 2024 •

edited by jira bot

Loading

SteveGT96 added 2 commits

October 3, 2024 16:55


          update(OP-1351): Change operation opeFor field to enum

137197b


          chore: Update migration steps

05e6c8e

dbmalkovsky reviewed

View reviewed changes

src/main/java/org/isf/operation/enums/OperationTarget.java Show resolved Hide resolved


          chore: Update OperationIoOperations repository and add license header…

82a17bb

… to OperationTarget

mwithi reviewed

View reviewed changes

sql/step_a110_update_operations_table_change_ope_for_to_enum.sql Outdated Show resolved Hide resolved

mwithi reviewed

View reviewed changes

src/main/java/org/isf/operation/enums/OperationTarget.java Outdated Show resolved Hide resolved

mwithi reviewed

View reviewed changes

src/main/java/org/isf/operation/model/Operation.java Outdated Show resolved Hide resolved

mwithi reviewed

View reviewed changes

src/main/java/org/isf/operation/model/Operation.java Outdated Show resolved Hide resolved

mwithi reviewed

View reviewed changes

src/main/java/org/isf/operation/service/OperationIoOperationRepository.java Outdated Show resolved Hide resolved

mwithi reviewed

View reviewed changes

src/test/java/org/isf/operation/Tests.java Outdated Show resolved Hide resolved

mwithi reviewed

View reviewed changes

sql/load_demo_data.sql Outdated Show resolved Hide resolved

SteveGT96 added 4 commits

October 4, 2024 08:50


          chore: Fix opeFor field and getOperation method

3671c82


          update: Update opeFor column definition

9228b9f


          update: Update opeFor field and fix operation tests

fcef0d2


          update: Update demo data

ce5657c

SteveGT96 mentioned this pull request

OP-1351 | Update operation opeFor field informatici/openhospital-gui#2062

Merged

SteveGT96 added 3 commits

October 4, 2024 10:19


          Merge branch 'develop' into update/OP-1351-change-OP_FOR-field

2ea1a17


          update: Update operation target enum

1283b4a


          fix: Update opeFor field metadata

14f186d

SteveGT96 requested a review from dbmalkovsky

October 4, 2024 10:35

mwithi reviewed

View reviewed changes

src/main/java/org/isf/operation/model/Operation.java Outdated Show resolved Hide resolved

mwithi reviewed

View reviewed changes

sql/step_a110_update_operations_table_change_ope_for_to_enum.sql Outdated Show resolved Hide resolved

SteveGT96 added 2 commits

October 4, 2024 11:49


          chore: Change enumeration order

fc10c96


          fix: Remove duplicate column definition

d5f3ffb

SilverD3 approved these changes

View reviewed changes

Contributor

SilverD3 left a comment

LGTM!

But we should immediately open an issue to align the GUI (and the API if needed).

Contributor Author

SteveGT96 commented Oct 7, 2024

LGTM!

But we should immediately open an issue to align the GUI (and the API if needed).

GUI: informatici/openhospital-gui#2062
An for the API is already opened(actually blocked by this).

SteveGT96 mentioned this pull request

OH2-389 | Provide operation context informatici/openhospital-api#477

Merged


          Merge branch 'develop' into update/OP-1351-change-OP_FOR-field

f6828da

mwithi approved these changes

View reviewed changes

Member

mwithi left a comment

LGTM. Thanks a lot!

mwithi merged commit 39ec947 into informatici:develop

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet