Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OP-1232 Improve api security config #510

Merged
merged 1 commit into from
Nov 26, 2024
Merged

OP-1232 Improve api security config #510

merged 1 commit into from
Nov 26, 2024

Conversation

mwithi
Copy link
Member

@mwithi mwithi commented Nov 26, 2024

Forgot to "make" new UI_HOST and UI_PORT placeholders

@mwithi mwithi requested a review from dbmalkovsky November 26, 2024 16:32
@mwithi mwithi changed the title OP-1232 Add missing variables for application.properties.dist OP-1232 Improve api security config Nov 26, 2024
dbmalkovsky
dbmalkovsky approved these changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@dbmalkovsky dbmalkovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbmalkovsky dbmalkovsky merged commit cfda2ca into develop Nov 26, 2024
4 checks passed
@dbmalkovsky dbmalkovsky deleted the mwithi_fix_cors_for_ui_docker branch November 26, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbmalkovsky dbmalkovsky dbmalkovsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mwithi @dbmalkovsky