Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement query client state command #132

Merged
merged 6 commits into from
Feb 9, 2024
Merged

Implement query client state command #132

merged 6 commits into from
Feb 9, 2024

Conversation

romac
Copy link
Member

@romac romac commented Feb 9, 2024 •
edited
Loading

Closes: #131
Closes: #133

Description

This PR also ports the Output type from Hermes and adds support for JSON output.

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@romac romac requested a review from ljoss17 February 9, 2024 12:12
@romac romac merged commit 58d221d into main Feb 9, 2024
10 checks passed
@romac romac deleted the romac/query-clients branch February 9, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljoss17 ljoss17 ljoss17 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for JSON output Implement query client state CLI for Cosmos chains
2 participants
@romac @ljoss17