Add missing dependencies to setup.py #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reasoning being that when any other app installs lispify as a dependency, pip doesn't look at the requirements.txt file at all. See https://caremad.io/2013/07/setup-vs-requirement/ for an excellent description of the different usage of a requirements.txt file and a setup.py file. In short, setup.py lists abstract dependencies which pip will install from PyPi or other sources listed in dependency_links and is used during normal installation. requirements.txt on the other hand is used during development. It's important to test installing using one and the other separately because it can help isolate bugs. requirements.txt is a list of dependencies that are frozen during development when known to work, and setup.py is a list of dependencies with perhaps some specification of version for incompatibilities, but otherwise completely abstract and versionless. The two lists can also diverge accidentally during development, and if problems arise one can compare the results of installing one way and the other to see what went wrong.
unittest2 backports the new features of unittest to Python 2.4+
Current coverage is 91.66% (diff: 100%)@@ master #7 diff @@
==========================================
Files 2 2
Lines 156 156
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 143 143
Misses 13 13
Partials 0 0
|
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #5 our
requirements.txtandsetup.pydependencies diverged, which resulted in failing WikipediaBase builds. This PR adjusts Travis to detect this issue, and then addresses the issue by adding the missing dependencies.For more details on the usage of
requirements.txtvs.setup.py, see the commit message in 86976a0.