Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update onboarding steps for Go v3 client #6987

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

karel-rehor
Copy link
Contributor

@karel-rehor karel-rehor commented Dec 13, 2024

Updates the onboarding steps for Go v3 client

Checklist

Authors and Reviewer(s), please verify the following:

  • A PR description, regardless of the triviality of this change, that communicates the value of this PR
  • Well-formatted conventional commit messages that provide context into the change
  • Documentation updated or issue created (provide link to issue/PR)
  • Signed CLA (if not already signed)
  • Feature flagged, if applicable

@karel-rehor karel-rehor requested a review from bednar December 13, 2024 14:10
@bednar bednar removed their request for review December 13, 2024 14:32
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my point of view, this looks good, and along with the new API for the client. Great job! 👍

@karel-rehor karel-rehor changed the title docs: update onboarding steps for select v3 clients docs: update onboarding steps for Go v3 client Dec 16, 2024
@karel-rehor
Copy link
Contributor Author

I've decided to go ahead with changes only to GO and will update Java onboarding in another branch. I'd rather we get this part of the UI updated ASAP instead of possibly having it held until January because of 1) Christmas Holidays 2) Unexpected obstacles in updating onboarding for Java.

BTW. Not sure what to do about the monitor-ci-tests and remocal. It seems there is an issue in the underlying system deployment apparently unrelated to these changes.

https://output.circle-artifacts.com/output/job/322ce1ff-e9f2-4414-9ebc-59ed3049eddd/artifacts/0/tests/e2e-remocal/e2e-test-remocal-deploy.log

Time limit has been exceeded. Giving up! Listing status of all pods:

NAME                                                              READY   STATUS             RESTARTS        AGE
annotationd-7b48589d76-n9g4w                                      1/1     Running            1 (8m7s ago)    8m8s
...
gateway-external-meta-595c495797-lw6fr                            0/1     CrashLoopBackOff   6 (107s ago)    8m10s
gateway-external-write-bbc4f748b-x9sj8                            0/1     CrashLoopBackOff   6 (107s ago)    8m11s
gateway-internal-meta-7584495fbf-8dclw                            0/1     CrashLoopBackOff   6 (110s ago)    8m10s
gateway-internal-write-744cf85dc8-89fdh                           0/1     CrashLoopBackOff   6 (2m1s ago)    8m11s
...
redpanda-0                                                        0/1     ImagePullBackOff   0               8m48s
...
storage-0                                                         0/1     CrashLoopBackOff   6 (2m14s ago)   8m11s
storage-1                                                         0/1     CrashLoopBackOff   6 (101s ago)    8m7s
...
Gathering ingress logs
Creating archive

@karel-rehor karel-rehor marked this pull request as ready for review December 16, 2024 09:23
@karel-rehor karel-rehor requested review from a team as code owners December 16, 2024 09:23
@david-rusnak
Copy link
Contributor

Hi @karel-rehor, sorry for the delay on this - I was working on fixing the CI pipeline and I see it has passed the tests now. I'll take a look at this PR in more detail tomorrow. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants