chore(ui): announcement cleanup #6975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eatondustin1
previously approved these changes
Nov 20, 2024
eatondustin1
dismissed
their stale review
Sorry, accidental approval prior to fully reviewing the changes.
eatondustin1
previously approved these changes
Nov 20, 2024
| } | ||
|
|
||
| enum AnnouncementState { | ||
| Dismissed = 'dismissed', | ||
| Display = 'display', | ||
| Disabled = 'disabled', |
There was a problem hiding this comment.
Is this new state being used anywhere?
There was a problem hiding this comment.
No, it's not. I added it for a different solution and forgot to remove it.
eatondustin1
approved these changes
Nov 20, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to remove code related to the Price Increase announcement and the MQTT EOL announcement. It leaves the component and handler in place for future announcements.
Checklist
Authors and Reviewer(s), please verify the following: