-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add Heap analytics #6951
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @peterbarnett03, I'll prioritize this and take a look at it today. In the meantime, do you know why the monitor-ci job is failing? Haven't had a chance to investigate
I'll pick this one up as part of the internal ticket we have for this. I think the CI failure is related to the mon ci runner changes we made recently so I can take a look. 👍 |
@blegesse-w @peterbarnett03 This should be ready for a re-review. I added a few things here to what Pete already included:
Overall I didn't see any regressions in behavior when I tested it local. This is less temperamental than the VWO script and the fetched scripts don't appear to interfere with page styles. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- appreciate you moving the ID to a dynamic flag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good to me. Anything else needs to be in place before merging?
Pending a final approval in https://github.com/influxdata/granite/issues/3358. |
CircleCI status page indicates jobs are failing. I'll wait until those resolve before re-merging. |
* chore: add Heap analytics * feat: unload analytics script on fail, use id appropriate to environment * fix: correct capitalization of heapanalyticsid --------- Co-authored-by: Peter Barnett <[email protected]> Co-authored-by: Bill OConnell <[email protected]>
This is re-enabling some UX analytics software so we can better understand usage patterns for future UI/UX updates across the InfluxData suite of products.
Checklist
Authors and Reviewer(s), please verify the following: