Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: combat flake on two most frequently flaking e2es #6919

Merged
merged 1 commit into from
Jul 30, 2024
+5 −3
Merged

fix: combat flake on two most frequently flaking e2es #6919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cypress.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"retries": {
"runMode": 2,
"runMode": 3,
"openMode": 0
},
"numTestsKeptInMemory": 25,
Expand Down
3 changes: 2 additions & 1 deletion cypress/e2e/shared/scriptQueryBuilder.results.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,8 @@ describe('Script Builder', () => {
})
})

it('will allow querying of different data ranges', () => {
// Temporarily disabled due to excess flake. Do not re-enable without rewriting this test.
it.skip('will allow querying of different data ranges', () => {
cy.log('Ensure LSP is online') // deflake
Comment on lines +109 to 111
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Turning off test for LSP due to its flakiness makes sense to me

cy.wait(DELAY_FOR_LSP_SERVER_BOOTUP)

Expand Down
3 changes: 2 additions & 1 deletion cypress/e2e/shared/tasks-searching.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,8 @@ describe('When tasks already exist', () => {
})
})

it('can clone a task and activate just the cloned one', () => {
// Skipped as too flaky - reintroduce only after rewriting.
it.skip('can clone a task and activate just the cloned one', () => {
const firstLabel = 'very important task'
const secondLabel = 'mission critical'

Expand Down
Loading