-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): Replace @babel/polyfill
with core-js
#6905
base: master
Are you sure you want to change the base?
Conversation
@wdoconnell or @eatondustin1 can you review this please? |
I haven't reviewed it yet because the monitor CI tests failed and the description gave me the impression that the changes might not be ready for review yet if CI failed. @abshierjoel can you confirm that the CI failures aren't related to your change?
|
@eatondustin1 @hansenreid Errors are from this monitor-ci pipeline. Not flake - failure is due to a ts file that manually imports wasm from src/index.tsx, which includes the babel-polyfill package that is no longer used. I actually do not see anywhere it's explicitly relied on anymore, so I have a commit removing it. @abshierjoel Are you okay if I commit into your branch? |
Discussed above at standup ^ |
There is still more to do here - BTW, C2 UI is unlike quartz in that all deploys progress automatically. So this is only testable in staging after the change is deployed as it is on the way to prod. |
Part of #1980
The @babel/polyfill package has been deprecated for some time now, and we should instead rely on
core-js
directly. I opted to useusage
so we wouldn't have to manually find the places to import the polyfills. I have some uncertainty of these changes, so I'd like to see if this passes CI and works in staging as expected. 🤞Checklist
Authors and Reviewer(s), please verify the following: