fix(ui): remove mentions of TSM-specific limits for Serverless users #6889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdoconnell
reviewed
Jul 30, 2024
| @@ -104,6 +104,15 @@ export const OrgLimits: FC = () => { | |||
| ) | |||
| } | |||
|
|
|||
| // The 'dashboards', 'tasks', 'checks', and 'rules' limits are not applicable to orgs using IOx. | |||
There was a problem hiding this comment.
Can we put this check at the beginning of the return/render, since it looks like it supersedes the other rules about which limits should be displayed?
| cardinality | ||
| </li> | ||
| <> | ||
| <li>Unlimited dashboards</li> |
There was a problem hiding this comment.
Does the absence of limits (no task limit, no alert limit, no pagerduty limit) only apply to TSM?
There was a problem hiding this comment.
Only TSM should get this message, I can see how that isn't very clear. I can restate it as a ternary on orgUsesIOx.
| <li>Unlimited dashboards</li> | ||
| <li>Unlimited tasks</li> | ||
| <li>Unlimited alert checks and notification rules</li> | ||
| <li>HTTP and PagerDuty notifications</li> | ||
| {!orgUsesIOx && ( |
There was a problem hiding this comment.
Same question as above.
|
@mavarius Do you need anything else on this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the mention of TSM-specific limits for Serverless users.
Checklist
Authors and Reviewer(s), please verify the following: