Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): add mqtt eol overlay and alert banner #6835

Merged
merged 3 commits into from
Nov 10, 2023

Conversation

mavarius
Copy link
Collaborator

@mavarius mavarius commented Nov 1, 2023

Closes #6828

This PR updates the click-through announcement overlay feature to be able to handle multiple sequential announcements. It also adds an announcement for the MQTT end-of-life. It adds a click-through overlay to the home page and a permanent alert banner on the Subscriptions page.

Alert Banner
Screenshot 2023-11-01 at 10 27 23 AM

Click-Through Overlay
Screenshot 2023-11-01 at 10 26 50 AM

Click-Through Overlay with Open FAQ Sections (scrolls)
Screenshot 2023-11-01 at 10 27 08 AM

Checklist

Authors and Reviewer(s), please verify the following:

  • A PR description, regardless of the triviality of this change, that communicates the value of this PR
  • Well-formatted conventional commit messages that provide context into the change
  • Feature flagged, if applicable

@mavarius mavarius requested a review from a team as a code owner November 1, 2023 17:47
Copy link
Contributor

@appletreeisyellow appletreeisyellow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat code! I have one suggestion below

src/homepageExperience/ClickThroughAnnouncementHandler.tsx Outdated Show resolved Hide resolved
@mavarius mavarius added this pull request to the merge queue Nov 10, 2023
Merged via the queue into master with commit 91e9f26 Nov 10, 2023
6 checks passed
@mavarius mavarius deleted the feat/mqtt-announcement branch November 10, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Native Collector - MQTT - End-of-Life Notification Messaging
2 participants