chore(tools): Bump golangci-lint from v1.53.2 to v1.54.2

[srebhan]

We need to bump the linter in order to be compatible with go 1.21 (see nightly build error for Windows). This PR bumps the linter and fixes the newly found issues.

[telegraf-tiger]

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB	RPM	TAR GZ	ZIP
amd64.deb	aarch64.rpm	darwin_amd64.tar.gz	windows_amd64.zip
arm64.deb	armel.rpm	darwin_arm64.tar.gz	windows_arm64.zip
armel.deb	armv6hl.rpm	freebsd_amd64.tar.gz	windows_i386.zip
armhf.deb	i386.rpm	freebsd_armv7.tar.gz
i386.deb	ppc64le.rpm	freebsd_i386.tar.gz
mips.deb	riscv64.rpm	linux_amd64.tar.gz
mipsel.deb	s390x.rpm	linux_arm64.tar.gz
ppc64el.deb	x86_64.rpm	linux_armel.tar.gz
riscv64.deb		linux_armhf.tar.gz
s390x.deb		linux_i386.tar.gz
		linux_mips.tar.gz
		linux_mipsel.tar.gz
		linux_ppc64le.tar.gz
		linux_riscv64.tar.gz
		linux_s390x.tar.gz

[zak-pawel]

@srebhan
About G601 findings you have fixed in this PR:

plugins/inputs/aliyuncms/aliyuncms.go:159:53               gosec  G601: Implicit memory aliasing in for loop.
plugins/inputs/aliyuncms/aliyuncms.go:162:54               gosec  G601: Implicit memory aliasing in for loop.
plugins/inputs/couchbase/couchbase.go:110:53               gosec  G601: Implicit memory aliasing in for loop.
plugins/inputs/logstash/logstash.go:459:35                 gosec  G601: Implicit memory aliasing in for loop.
plugins/inputs/vsphere/endpoint.go:654:41                  gosec  G601: Implicit memory aliasing in for loop.
plugins/inputs/vsphere/endpoint.go:700:42                  gosec  G601: Implicit memory aliasing in for loop.
plugins/inputs/vsphere/endpoint.go:724:41                  gosec  G601: Implicit memory aliasing in for loop.
plugins/inputs/vsphere/endpoint.go:753:41                  gosec  G601: Implicit memory aliasing in for loop.
plugins/inputs/vsphere/endpoint.go:859:41                  gosec  G601: Implicit memory aliasing in for loop.
plugins/inputs/vsphere/endpoint.go:888:41                  gosec  G601: Implicit memory aliasing in for loop.
plugins/outputs/cloudwatch_logs/cloudwatch_logs.go:378:34  gosec  G601: Implicit memory aliasing in for loop.
plugins/outputs/iotdb/iotdb_test.go:268:27                 gosec  G601: Implicit memory aliasing in for loop.
plugins/outputs/iotdb/iotdb_test.go:348:55                 gosec  G601: Implicit memory aliasing in for loop.
plugins/outputs/iotdb/iotdb_test.go:482:28                 gosec  G601: Implicit memory aliasing in for loop.
plugins/outputs/iotdb/iotdb_test.go:484:31                 gosec  G601: Implicit memory aliasing in for loop.

I believe that most of them are false-positives.

This PR introduced code which found these issues: securego/gosec#966 and fix was made here securego/gosec#1003

I believe that mentioned fix hasn't been yet released (it is not contained in latest v2.17.0.

[srebhan]

@zak-pawel I'm not so sure about those being false positives. Most of them take the address of an iterator and pass it on to other functions. While this works in those cases it is fragile because as soon as you store that pointer in any of the sub-routines you get into trouble. As we do not modify the value in the pointer in almost all cases I pass the data (mostly strings) by value rather than passing the pointer...

[zak-pawel]

@zak-pawel I'm not so sure about those being false positives. Most of them take the address of an iterator and pass it on to other functions. While this works in those cases it is fragile because as soon as you store that pointer in any of the sub-routines you get into trouble. As we do not modify the value in the pointer in almost all cases I pass the data (mostly strings) by value rather than passing the pointer...

I can agree with your explanation :)