chore: move separate cli and server tests #25934
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgattozzi
requested review from
pauldix,
waynr,
hiltontj,
jacksonrnewhouse and
praveen-influx
mgattozzi
force-pushed
the
mgattozzi/test-cleanup
branch
2 times, most recently
from
60e8a67 to
4b1fb59
Compare
This commit restructures our tests to look like Enterprise in their layout. We break cli.rs into it's own module, combine the server tests and cli tests under one lib.rs file and handle the changes for visibility and import paths needed to make things work. the packages tests have been cfged out as a module so that it would not need to be added on a per test basis. Note that those tests fail locally for me currently, but it seems like we weren't testing these in CI at the moment. There is no issue for this.
mgattozzi
force-pushed
the
mgattozzi/test-cleanup
branch
from
4b1fb59 to
34a1f44
Compare
mgattozzi
changed the title
hiltontj
approved these changes
Jan 30, 2025
|
Huh, I can't see why the semantic check is failing. Your PR title and commit are fine... |
|
I'm not sure the old ones were removed. I can go through and prune them. It'll also let us repush things and hopefully get a CI run that passes. Plus it looks like we had more changes to tests causing more conflicts so I'll need to rebase again anyways. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit restructures our tests to look like Enterprise in their layout. We break cli.rs into it's own module, combine the server tests and cli tests under one lib.rs file and handle the changes for visibility and import paths needed to make things work. the packages tests have been cfged out as a module so that it would not need to be added on a per test basis. Note that those tests fail locally for me currently, but it seems like we weren't testing these in CI at the moment.
There is no issue for this.
@jacksonrnewhouse I want to make sure that my changes to the cfg for the packages.rs test file being cfged out make sense. Especially given that these do not pass for me right now and we don't run them in CI from what I could see.