Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): add csv dependency as required by ruby 3.3 #137

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

akarzim
Copy link
Contributor

@akarzim akarzim commented Nov 20, 2024

Closes #136

Proposed Changes

Add the csv gem to the gemspec dependencies.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • rake test completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.23%. Comparing base (6acd2b3) to head (1ed1d81).
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #137      +/-   ##
==========================================
- Coverage   48.23%   48.23%   -0.01%     
==========================================
  Files          77       77              
  Lines        7948     7947       -1     
==========================================
- Hits         3834     3833       -1     
  Misses       4114     4114              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here’s a refined version of your message:

@akarzim, thank you for your contribution! 👍

Please update the CHANGELOG.md. Once that’s done, we can proceed with merging your PR.

Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for your PR! 👍

@bednar bednar added this to the 3.2.0 milestone Nov 20, 2024
@bednar bednar merged commit ffa02d0 into influxdata:master Nov 20, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CSV dependency explicitly
3 participants