Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write 2 points in example.py #683

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

matleg
Copy link

@matleg matleg commented Dec 5, 2024

Closes #

Proposed Changes

Create and write 2 points instead of one in the example.py file.

Previously, the second write (with the line_protocol) erased the first write (with the Point structure) as timestamps are the same. Besides, the WritePrecision.MS made the line_protocol time conversion to somewhere in February 1970 (at time of writing), instead of current date & time.

So it is proposed here to write two distinct points to improve example understanding, and remove the WritePrecision.MS when writing with line_protocol, as is done in other examples, in order to write both points at the timestamp of execution.

Checklist

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.20%. Comparing base (ab16384) to head (c250e8e).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #683      +/-   ##
==========================================
- Coverage   90.28%   90.20%   -0.08%     
==========================================
  Files          40       40              
  Lines        3541     3533       -8     
==========================================
- Hits         3197     3187      -10     
- Misses        344      346       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bednar bednar requested a review from karel-rehor December 5, 2024 14:08
@bednar bednar requested review from vlastahajek and removed request for karel-rehor December 5, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants