chore: update to rust 1.82 #5509
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crepererum
commented
Nov 5, 2024
| @@ -173,38 +173,32 @@ fn infer_types( | |||
| /// # Example | |||
| /// | |||
| /// ``` | |||
| /// #[test] | |||
There was a problem hiding this comment.
tests within doctests were never supported and Rust now complains about that
crepererum
commented
Nov 5, 2024
| @@ -1,5 +1,5 @@ | |||
| [toolchain] | |||
| channel = "1.72" | |||
| channel = "1.82" | |||
There was a problem hiding this comment.
bumped hoping that this fixes the build issues on windows
crepererum
commented
Nov 5, 2024
| @@ -1,5 +1,6 @@ | |||
| [workspace] | |||
| members = ["flux-core", "flux"] | |||
| resolver = "2" | |||
There was a problem hiding this comment.
apparently workspaces w/ edition 2021 crates default to the v2 resolver, this just makes it explicit and silences a cargo warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Dear Author 👋, the following checks should be completed (or explicitly dismissed) before merging.
experimental/docs/Spec.mdhas been updatedDear Reviewer(s) 👋, you are responsible (among others) for ensuring the completeness and quality of the above before approval.