Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade github.com/benbjohnson/immutable #5488

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Conversation

mhilton
Copy link
Contributor

@mhilton mhilton commented Jun 5, 2024

Newer versions of this package were changed to use generics, making them incompatible with the current code. Update to the newest version. This has the nice side effect of reducing the amount of type assertions.

Closes #5477

Checklist

Dear Author 👋, the following checks should be completed (or explicitly dismissed) before merging.

  • ✏️ Write a PR description, regardless of triviality, to include the value of this PR
  • 🔗 Reference related issues
  • 🏃 Test cases are included to exercise the new code
  • 🧪 If new packages are being introduced to stdlib, link to Working Group discussion notes and ensure it lands under experimental/
  • 📖 If language features are changing, ensure docs/Spec.md has been updated

Dear Reviewer(s) 👋, you are responsible (among others) for ensuring the completeness and quality of the above before approval.

Newer versions of this package were changed to use generics, making
them incompatible with the current code. Update to the newest
version. This has the nice side effect of reducing the amount of
type assertions.
@mhilton mhilton self-assigned this Jun 5, 2024
@mhilton mhilton requested a review from a team as a code owner June 5, 2024 10:25
Copy link
Contributor

@appletreeisyellow appletreeisyellow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of this @mhilton!

@mhilton mhilton merged commit 165b17e into master Jun 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build issue
3 participants