Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update github.com/SAP/go-hdb #5487

Merged
merged 1 commit into from
Jun 5, 2024
Merged

fix: update github.com/SAP/go-hdb #5487

merged 1 commit into from
Jun 5, 2024

Conversation

mhilton
Copy link
Contributor

@mhilton mhilton commented Jun 5, 2024

We have reports that the declared version does not exist any more so update to the latest version. This does not appear to actually change the vendored code.

Closes #5462

Checklist

Dear Author 👋, the following checks should be completed (or explicitly dismissed) before merging.

  • ✏️ Write a PR description, regardless of triviality, to include the value of this PR
  • 🔗 Reference related issues
  • 🏃 Test cases are included to exercise the new code
  • 🧪 If new packages are being introduced to stdlib, link to Working Group discussion notes and ensure it lands under experimental/
  • 📖 If language features are changing, ensure docs/Spec.md has been updated

Dear Reviewer(s) 👋, you are responsible (among others) for ensuring the completeness and quality of the above before approval.

We have reports that the declared version does not exist any more
so update to the latest version. This does not appear to actually
change the vendored code.
@mhilton mhilton requested a review from a team as a code owner June 5, 2024 09:11
@mhilton mhilton self-assigned this Jun 5, 2024
@mhilton mhilton merged commit fc18931 into master Jun 5, 2024
7 checks passed
@shaonamzn
Copy link

shaonamzn commented Jun 5, 2024

Are you going to create a new tag with this change?

@mhilton
Copy link
Contributor Author

mhilton commented Jun 6, 2024

Are you going to create a new tag with this change?

Yes, I'm intending to do a release in the next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade github.com/SAP/go-hdb to V1
4 participants