Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advance DF 0ct-30 by SPM round-robin commit. #49

Draft
wants to merge 10 commits into
base: df-upgrade-base-oct-30
Choose a base branch
from

Conversation

wiedld
Copy link
Collaborator

@wiedld wiedld commented Dec 13, 2024

Refer to this PR for the list of patches:
#48

How the different "oct-30" upgrades are related:

  1. We were on commit 922b399 with the original Oct-30 upgrade in iox.
    • this included the revert of the stringview enablement

.

  1. we then "advanced" by a single commit, by pointing iox to the commit before the stringview revert. 50e1209
Screenshot 2024-12-17 at 6 14 03 PM

.

  1. now we have a new branch, that adds back the single commit for SPM round robin.
Screenshot 2024-12-17 at 6 19 49 PM

…ache#13133)

* first draft

Signed-off-by: jayzhan211 <[email protected]>

* add data

Signed-off-by: jayzhan211 <[email protected]>

* fix benchmark

Signed-off-by: jayzhan211 <[email protected]>

* add more bencmark data

Signed-off-by: jayzhan211 <[email protected]>

* fix benchmark

Signed-off-by: jayzhan211 <[email protected]>

* fmt

Signed-off-by: jayzhan211 <[email protected]>

* get max size

Signed-off-by: jayzhan211 <[email protected]>

* add license

Signed-off-by: jayzhan211 <[email protected]>

* rm code for merge

Signed-off-by: jayzhan211 <[email protected]>

* cleanup

Signed-off-by: jayzhan211 <[email protected]>

* cleanup

Signed-off-by: jayzhan211 <[email protected]>

* update poll count only we have tie

Signed-off-by: jayzhan211 <[email protected]>

* upd comment

Signed-off-by: jayzhan211 <[email protected]>

* fix logic

Signed-off-by: jayzhan211 <[email protected]>

* configurable

Signed-off-by: jayzhan211 <[email protected]>

* fmt

Signed-off-by: jayzhan211 <[email protected]>

* add mem limit test

Signed-off-by: jayzhan211 <[email protected]>

* rm test

Signed-off-by: jayzhan211 <[email protected]>

* escape bracket

Signed-off-by: jayzhan211 <[email protected]>

* add test

Signed-off-by: jayzhan211 <[email protected]>

* rm per consumer record

Signed-off-by: jayzhan211 <[email protected]>

* repartition limit

Signed-off-by: jayzhan211 <[email protected]>

* add benchmark

Signed-off-by: jayzhan211 <[email protected]>

* cleanup

Signed-off-by: jayzhan211 <[email protected]>

* benchmark with parameter

Signed-off-by: jayzhan211 <[email protected]>

* only calculate consumer pool if the limit is set

Signed-off-by: jayzhan211 <[email protected]>

* combine eq and gt

Signed-off-by: jayzhan211 <[email protected]>

* review part 1

* Update merge.rs

* upd doc

Signed-off-by: jayzhan211 <[email protected]>

* no need index comparison

Signed-off-by: jayzhan211 <[email protected]>

* combine handle tie and eq check

Signed-off-by: jayzhan211 <[email protected]>

* upd doc

Signed-off-by: jayzhan211 <[email protected]>

* fmt

Signed-off-by: jayzhan211 <[email protected]>

* add more comment

Signed-off-by: jayzhan211 <[email protected]>

* remove flag

Signed-off-by: jayzhan211 <[email protected]>

* upd comment

Signed-off-by: jayzhan211 <[email protected]>

* Revert "remove flag"

This reverts commit 8d6c0a6.

* Revert "upd comment"

This reverts commit a18cba8.

* add more comment

Signed-off-by: jayzhan211 <[email protected]>

* add more comment

Signed-off-by: jayzhan211 <[email protected]>

* fmt

Signed-off-by: jayzhan211 <[email protected]>

* simpliy mem pool

Signed-off-by: jayzhan211 <[email protected]>

* clippy

Signed-off-by: jayzhan211 <[email protected]>

* Update merge.rs

* minor

* add comment

Signed-off-by: jayzhan211 <[email protected]>

---------

Signed-off-by: jayzhan211 <[email protected]>
Co-authored-by: berkaysynnada <[email protected]>
@wiedld wiedld force-pushed the dlw/oct-30-with-spm-change branch from 0ee794c to ae0a57b Compare December 18, 2024 02:08
@wiedld wiedld changed the base branch from iox-12627/patched-DF-oct-30 to df-upgrade-base-oct-30 December 18, 2024 02:10
@alamb
Copy link
Collaborator

alamb commented Dec 18, 2024

❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants