Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP(iox-10893): patched df upgrade 2024-06-22 #29

Closed
wants to merge 5 commits into from

Conversation

appletreeisyellow
Copy link

@appletreeisyellow appletreeisyellow commented Jun 25, 2024

⚠️ This will not be merged. ⚠️

  1. Bringing us up to datafusion to 2024-06-22, apache@ea46e82

  2. This PR is based on 2024-06-16 apache@d4228fe

    git co -b chunchun/update-df-june-week-3 d4228feca341cd707a3a26372cae71a94a93b4fd
    
  3. Cherry-picked the following commits:

    1. Consider timezones with UTC and +00:00 to be the same apache/datafusion#10960 / apache@4a0c7f3

      commit 4a0c7f35a02ef71fcea518a3566edc9b56866cae
      Author: Marvin Lanhenke <[email protected]>
      Date:   Fri Jun 21 18:18:14 2024 +0200
      
          Consider timezones with  `UTC` and `+00:00` to be the same (#10960)
    2. Support dictionary data type in array_to_string apache/datafusion#10908 / apache@8d8dd90

      commit 8d8dd9075d4fb54c0d3467916bb66459d7a26b2f
      Author: Eduardo Vega <[email protected]>
      Date:   Sun Jun 23 04:14:40 2024 -0600
      
          Support dictionary data type in array_to_string (#10908)

marvinlanhenke and others added 3 commits June 25, 2024 12:17
* feat: add temporal_coercion check

* fix: add return stmt

* chore: add slts

* fix: remove println

* Update datafusion/expr/src/type_coercion/binary.rs

---------

Co-authored-by: Andrew Lamb <[email protected]>
* Support dictionary data type in array_to_string

* Fix import

* Some tests

* Update datafusion/functions-array/src/string.rs

Co-authored-by: Alex Huang <[email protected]>

* Add some tests showing incorrect results

* Get logical array

* apply rust fmt

* Simplify implementation, avoid panics

---------

Co-authored-by: Alex Huang <[email protected]>
Co-authored-by: Andrew Lamb <[email protected]>
@appletreeisyellow appletreeisyellow changed the title WIP(iox-10893): patched df upgrade 202-06-TBD WIP(iox-10893): patched df upgrade 202-06-22 Jun 26, 2024
@appletreeisyellow appletreeisyellow changed the title WIP(iox-10893): patched df upgrade 202-06-22 WIP(iox-10893): patched df upgrade 2024-06-22 Jul 11, 2024
@appletreeisyellow
Copy link
Author

Closing since the upgrade is done

@appletreeisyellow appletreeisyellow deleted the chunchun/update-df-june-week-3 branch July 12, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants