New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔥 Remove unused var which trigger scarb warnings #35

Merged

clexmond merged 1 commit into influenceth:main from bal7hazar:fix/unused-var

May 14, 2024

Contributor

bal7hazar commented May 8, 2024

Minor modification to remove an unused variable which triggers the following scarb warning on projects that use cubit as dependancy:

warning: Unused variable. Consider ignoring by prefixing with `_`.
 --> /Users/.../Library/Caches/com.swmansion.scarb/registry/git/checkouts/cubit-k9rijvovof89o/09cb8c2/src/f64/math/trig.cairo:453:13
        let pi = FixedTrait::new(PI, false);
            ^^


          🔥 Remove unused var which trigger scarb warnings

6bcdf00

Contributor Author

bal7hazar commented May 13, 2024

clexmond approved these changes

View reviewed changes

clexmond merged commit 8eacc2b into influenceth:main

1 check passed

bal7hazar deleted the fix/unused-var branch

May 14, 2024 13:52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet