Added getters in FluvioError and made example js use it #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #28.
This exposes the message, name and stack for the
FluvioErrorwrapper.I've also updated the example for it.
I've tested this across three browsers (ff 89, ff 90 and chromium). With my local setup, the websocket never dies, when I move to a different tab, the timeout goes from 50ms to ~500ms. I think that's just due to the js runtime when the tab is in the background.
I've tested that the try-catch logic works by starting all the browsers and then killing the websocket proxy. It's pretty instant in ff 90 and chromium but takes upwards of 10 seconds in ff 89. Not sure what's up with that.
Anyway, for now we can use try-catch.