Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding multiple fixes #410

Merged
merged 2 commits into from
Jun 14, 2024
Merged

adding multiple fixes #410

merged 2 commits into from
Jun 14, 2024

Conversation

iruzevic
Copy link
Member

Added

  • Media support for svg and json.
  • Optimization service class for better performance.

Fixed

  • Phpstan config fix for theme and plugin setup
  • Project name variable will now be ucfirst on setup.
  • Removed .git folder after the setup.

piqusy
piqusy previously approved these changes Jun 13, 2024
Copy link
Contributor

@piqusy piqusy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kancijan kancijan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor remark

src/Media/AbstractMedia.php Outdated Show resolved Hide resolved
@iruzevic iruzevic merged commit cc6b2f6 into develop Jun 14, 2024
4 checks passed
@iruzevic iruzevic deleted the feature/multiple-fixes branch June 14, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants