Apply suggestions from code review

Co-authored-by: Ivan Kancijan <[email protected]>
infinum · Jun 14, 2024 · 5d95d45 · 5d95d45
1 parent 8c6070f
commit 5d95d45
Showing 1 changed file with 14 additions and 13 deletions.
diff --git a/src/Media/AbstractMedia.php b/src/Media/AbstractMedia.php
@@ -148,22 +148,23 @@ public function enableSvgMediaLibraryPreview($response, $attachment)
 	 */
 	public function validateSvgOnUpload($response)
 	{
-		if ($response['type'] === 'image/svg+xml' && \class_exists('SimpleXMLElement')) {
-			$path = $response['tmp_name'];
+		if ($response['type'] !== 'image/svg+xml' && !\class_exists('SimpleXMLElement')) {
+			return $response;
+		}
 
-			$svgContent = \file($path);
-			$svgContent = \implode(' ', $svgContent);
+		$path = $response['tmp_name'] ?? '';
 
-			if (\file_exists($path)) {
-				if (!Helpers::isValidXml($svgContent)) {
-					return [
-						'size' => $response,
-						'name' => $response['name'],
-					];
-				}
-			}
+		$svgContent = \file($path);
+		$svgContent = \implode(' ', $svgContent);
+
+		if (!\file_exists($path) || Helpers::isValidXml($svgContent)) {
+			return $response;
 		}
-		return $response;
+
+		return [
+			'size' => $response,
+			'name' => $response['name'],
+		];
 	}
 
 	/**