Removed BrowserSync from depenencies #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iruzevic
requested changes
Jul 5, 2024
iruzevic
previously approved these changes
Jul 5, 2024
iruzevic
previously approved these changes
Jul 5, 2024
goranalkovic-infinum
requested changes
Jul 5, 2024
linters/ignore-gitignored.mjs
Outdated
| const dirname = path.dirname(filename); | ||
| const gitignorePath = path.resolve(dirname, '.gitignore'); | ||
|
|
||
| export default [includeIgnoreFile(gitignorePath)]; |
There was a problem hiding this comment.
Suggested change
| export default [includeIgnoreFile(gitignorePath)]; | |
| export default [includeIgnoreFile(gitignorePath)]; | |
package.json
Outdated
| @@ -77,6 +74,7 @@ | |||
| "postcss": "^8.4.38", | |||
| "postcss-loader": "^8.1.1", | |||
| "postcss-scss": "^4.0.9", | |||
| "prettier": "^3.3.2", | |||
There was a problem hiding this comment.
Remove all Prettier-related things, it wouldn't be too wise to add them to the existing setup (there would probably be a loooot of re-formatting 😄)
goranalkovic-infinum
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed BrowserSync as a project dependency.
I searched the whole project for potential usages and found none, and ran linters as well to detect possible issues.
Also updated ES lint config files based on a new setup.