Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/reaction speed test #44

Merged
merged 9 commits into from
Nov 9, 2024
Merged

Feature/reaction speed test #44

merged 9 commits into from
Nov 9, 2024

Conversation

JAM-PARK
Copy link
Member

@JAM-PARK JAM-PARK commented Nov 2, 2024

설명 (Description)

  • pnpm gen부터 web:publish, @infinite-loop-factory/config-typescript/native.json 적용까지 (최대한) 반영했습니다

관련 이슈 (Related Issues)

변경 내용 (Changes Made)

  • pnpm gen 👉 create-module 👉 native
  • (tabs) 제거, (pages) expo routing Groups 적용
  • expo router
  • gluestack button
  • web:publish
  • @infinite-loop-factory/config-typescript/native.json 적용

체크리스트 (Checklist)

  • iOS에서 테스트 완료
  • Android에서 테스트 완료
  • 웹에서 테스트 완료

추가 정보 (Additional Context)

문제점이 있습니다🥲
웹뷰 페이지에서 reaction-speed-test를 선택하면
children이 (전체화면으로) 렌더링됩니다...

여기 조건에 걸리는 것으로 보이는데요

if (typeof window !== "undefined") return children;

삽질에 수확이 없었습니다... 은광님 규범님과 같은 화면 구현이 안되네요 (웹뷰는 작은 View에, pnpm start 👉 w은 전체화면)
유일한 방법이

// 아래 조건 주석 처리
// if (typeof window !== "undefined") return children;

후에 pnpm web:publish커맨드 실행하기인데 찜찜하네요...!

제 앱이랑 기존 앱들의 다른점은

(tabs) 제거, (pages) expo routing Groups 적용

이것뿐이라고 생각합니다..!

어떻게 처리하면 좋을까요?

@JAM-PARK JAM-PARK added feat New feature or request size/xl labels Nov 2, 2024
@JAM-PARK JAM-PARK self-assigned this Nov 2, 2024
@JAM-PARK JAM-PARK requested a review from a team as a code owner November 2, 2024 10:51
Copy link
Contributor

github-actions bot commented Nov 2, 2024

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@ckrbqja
Copy link
Member

ckrbqja commented Nov 2, 2024

맞아용!
!== 아니고 ===로 바꾸면 잘 될거에요!
지금 외부라 집가서 한 번 확인 해보겠습니다

바꾸고 하면 잘 될거에여

@JAM-PARK JAM-PARK force-pushed the feature/reaction-speed-test branch from 1456b62 to d912d4e Compare November 4, 2024 14:52
@CLAassistant
Copy link

CLAassistant commented Nov 4, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

github-actions bot commented Nov 4, 2024

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@JAM-PARK JAM-PARK force-pushed the feature/reaction-speed-test branch from d912d4e to 243eeda Compare November 7, 2024 11:07
Copy link
Contributor

github-actions bot commented Nov 7, 2024

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@JAM-PARK JAM-PARK merged commit d76d236 into main Nov 9, 2024
3 checks passed
@JAM-PARK JAM-PARK deleted the feature/reaction-speed-test branch November 9, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request size/xl
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants