Missing keys - rules and notifications - 2nd try #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @infertux, what is the state of this PR, can we help to get this merged? |
infertux
force-pushed
the
master
branch
2 times, most recently
from
5c445db to
506f1f9
Compare
infertux
force-pushed
the
master
branch
20 times, most recently
from
5ec75ac to
88590bc
Compare
infertux
force-pushed
the
master
branch
17 times, most recently
from
186f49c to
7871b04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a new pull request for "missing key notifications" feature:
However I felt the need to change more of the code and tests - more dependency injection.
The handling of the configuration file and the log configuration happens now outside the
central zeyple class.