Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: side-effect handling #174

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: side-effect handling #174

wants to merge 1 commit into from

Conversation

gimhol
Copy link

@gimhol gimhol commented Aug 5, 2022

there is a div is added to body before "Viewer" mounted.
It needs to be removed when "Viewer" unmounted or it will always exist in the body element.

@gimhol
Copy link
Author

gimhol commented Aug 5, 2022

@infeng 麻烦看看这个问题

Flickza
Flickza approved these changes Oct 19, 2022
View reviewed changes
Copy link

@Flickza Flickza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked into this too, this was creating a bug for me.
This needs to be comitted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flickza Flickza Flickza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gimhol @Flickza