Skip to content
This repository has been archived by the owner on May 30, 2019. It is now read-only.

Read server's ISUPPORT and get prefix there #101

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

14mRh4X0r
Copy link
Contributor

Also stores the ISUPPORT parameters in an easily accessible HashMap and fixes a slight parsing bug with IRCv3 message tags

@indrora
Copy link
Owner

indrora commented Oct 23, 2015

There's deeper places that this should be handled.

Notably, pIRCbot is hard-coded to say that v means + and o means @.

@indrora
Copy link
Owner

indrora commented Oct 23, 2015

Second quick check: how well does the IETF document line up with http://www.irc.org/tech_docs/005.html ?

@14mRh4X0r
Copy link
Contributor Author

I'll update this pull request later with an implementation on a deeper level. The IETF document matches the irc.org doc as far as I can tell, but the latter does provide more information about real-world implementations.

@indrora
Copy link
Owner

indrora commented Nov 2, 2015

I'd like IRCService to be able to tell what the ISUPPORT blocks state. This way, we can strip out the nick prefixes (and handle things like the absolutely strange $foo channel type that I encountered)

@14mRh4X0r
Copy link
Contributor Author

As my local version is now, PircBot has a Map<String, String> getISupport(). It requires more rewriting than I anticipated.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants