-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Home support to base class #2090
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is one more call in the code and it overwrites indi/drivers/telescope/lx200am5.cpp Lines 80 to 81 in 2be3539
|
To check compatibility, the argument should not have the default value of 0. void SetTelescopeCapability(uint32_t cap, uint8_t slewRateCount, uint8_t homeCapability = 0); Why don't you want to add these options to a 32-bit variable? There's still some space :) enum
{
TELESCOPE_CAN_GOTO = 1 << 0, /** Can the telescope go to to specific coordinates? */
TELESCOPE_CAN_SYNC = 1 << 1, /** Can the telescope sync to specific coordinates? */
TELESCOPE_CAN_PARK = 1 << 2, /** Can the telescope park? */
TELESCOPE_CAN_ABORT = 1 << 3, /** Can the telescope abort motion? */
TELESCOPE_HAS_TIME = 1 << 4, /** Does the telescope have configurable date and time settings? */
TELESCOPE_HAS_LOCATION = 1 << 5, /** Does the telescope have configuration location settings? */
TELESCOPE_HAS_PIER_SIDE = 1 << 6, /** Does the telescope have pier side property? */
TELESCOPE_HAS_PEC = 1 << 7, /** Does the telescope have PEC playback? */
TELESCOPE_HAS_TRACK_MODE = 1 << 8, /** Does the telescope have track modes (sidereal, lunar, solar..etc)? */
TELESCOPE_CAN_CONTROL_TRACK = 1 << 9, /** Can the telescope engage and disengage tracking? */
TELESCOPE_HAS_TRACK_RATE = 1 << 10, /** Does the telescope have custom track rates? */
TELESCOPE_HAS_PIER_SIDE_SIMULATION = 1 << 11, /** Does the telescope simulate the pier side property? */
TELESCOPE_CAN_TRACK_SATELLITE = 1 << 12, /** Can the telescope track satellites? */
TELESCOPE_CAN_FLIP = 1 << 13, /** Does the telescope have a command for flipping? */
TELESCOPE_HOME_FIND = 1 << 14, /*!< Mount can search for home position */
TELESCOPE_HOME_SET = 1 << 15, /*!< Mount can use current-position as home position */
TELESCOPE_HOME_GO = 1 << 16, /*!< Mount can slew to home position */
} TelescopeCapability; |
pawel-soja
reviewed
Jul 28, 2024
pawel-soja
reviewed
Jul 28, 2024
Thank you for the suggestion, I'll make the necessary changes tomorrow. |
…embers, we need to check by name for the required action.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since several mounts support Homing controls. This PR moves the responsibility of defining available homing operations to the INDI::Telescope class. Three operations are currently supported and any combination of the three can be set by the concrete class:
Both Find and Go are transient operations so the driver must set the status of HomeSP to OK and must also reset all members of the switch property.