Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cmake): rework static/shared/object build. #2036

Merged
merged 1 commit into from
Mar 28, 2024
+67 −45
Merged

fix(cmake): rework static/shared/object build. #2036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,13 @@ if(INDI_BUILD_DRIVERS)
include_directories(${ZLIB_INCLUDE_DIR})
include_directories(libs/indibase)
include_directories(libs/indibase/timer)
include_directories(libs/indiclient)
include_directories(libs/indiabstractclient)
include_directories(libs/indicore)
include_directories(libs/indidevice)
include_directories(libs/indidevice/property)
include_directories(${CMAKE_CURRENT_BINARY_DIR}/libs/indicore)


configure_file(${CMAKE_CURRENT_SOURCE_DIR}/config-usb.h.cmake ${CMAKE_CURRENT_BINARY_DIR}/config-usb.h)

Expand Down
105 changes: 60 additions & 45 deletions libs/indibase/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,79 +215,94 @@ list(APPEND ${PROJECT_NAME}_PRIVATE_HEADERS
# TODO
)

# Build Object Library
add_library(${PROJECT_NAME}_OBJECT OBJECT)
set_property(TARGET ${PROJECT_NAME}_OBJECT PROPERTY POSITION_INDEPENDENT_CODE 1)

target_compile_definitions(${PROJECT_NAME}_OBJECT PRIVATE "-DHAVE_LIBNOVA")
# If we build a shared library, we link other build products to it
# If we do not build a shared library, we link the static library
# If we build neither, we linke the object library
if(INDI_BUILD_SHARED)
set(TARGET_SHARED ${PROJECT_NAME})
set(TARGET_STATIC ${PROJECT_NAME}_STATIC)
set(TARGET_OBJECT ${PROJECT_NAME}_OBJECT)
elseif(INDI_BUILD_STATIC)
set(TARGET_STATIC ${PROJECT_NAME})
set(TARGET_OBJECT ${PROJECT_NAME}_OBJECT)
else()
set(TARGET_OBJECT ${PROJECT_NAME})
endif()

target_sources(${PROJECT_NAME}_OBJECT
PUBLIC
${${PROJECT_NAME}_HEADERS}
PRIVATE
${${PROJECT_NAME}_SOURCES}
${${PROJECT_NAME}_PRIVATE_HEADERS}
)
# Build Object Library
if(TRUE)
add_library(${PROJECT_NAME}_OBJECT OBJECT)
set_property(TARGET ${PROJECT_NAME}_OBJECT PROPERTY POSITION_INDEPENDENT_CODE 1)

target_compile_definitions(${PROJECT_NAME}_OBJECT PRIVATE "-DHAVE_LIBNOVA")

target_sources(${PROJECT_NAME}_OBJECT
PUBLIC
${${PROJECT_NAME}_HEADERS}
PRIVATE
${${PROJECT_NAME}_SOURCES}
${${PROJECT_NAME}_PRIVATE_HEADERS}
)

target_link_libraries(${PROJECT_NAME}_OBJECT ${${PROJECT_NAME}_LIBS})
target_link_libraries(${PROJECT_NAME}_OBJECT ${${PROJECT_NAME}_LIBS})

install(FILES
${${PROJECT_NAME}_HEADERS}
DESTINATION
${INCLUDE_INSTALL_DIR}/libindi
COMPONENT Devel
)
install(FILES
${${PROJECT_NAME}_HEADERS}
DESTINATION
${INCLUDE_INSTALL_DIR}/libindi
COMPONENT Devel
)

install(FILES
connectionplugins/connectioninterface.h
connectionplugins/connectionserial.h
connectionplugins/connectiontcp.h
DESTINATION ${INCLUDE_INSTALL_DIR}/libindi/connectionplugins
COMPONENT Devel
)
install(FILES
connectionplugins/connectioninterface.h
connectionplugins/connectionserial.h
connectionplugins/connectiontcp.h
DESTINATION ${INCLUDE_INSTALL_DIR}/libindi/connectionplugins
COMPONENT Devel
)

install(FILES
dsp/manager.h
dsp/dspinterface.h
dsp/transforms.h
dsp/convolution.h
DESTINATION ${INCLUDE_INSTALL_DIR}/libindi/dsp
COMPONENT Devel
)
install(FILES
dsp/manager.h
dsp/dspinterface.h
dsp/transforms.h
dsp/convolution.h
DESTINATION ${INCLUDE_INSTALL_DIR}/libindi/dsp
COMPONENT Devel
)
endif()

# Build Static Library
if(INDI_BUILD_STATIC)
add_library(${PROJECT_NAME}static STATIC)
add_library(${TARGET_STATIC} STATIC)

target_link_libraries(${PROJECT_NAME}static ${PROJECT_NAME}_OBJECT ${${PROJECT_NAME}_LIBS})
target_include_directories(${PROJECT_NAME}static PUBLIC .)
target_link_libraries(${TARGET_STATIC} ${TARGET_OBJECT} ${${PROJECT_NAME}_LIBS})
target_include_directories(${TARGET_STATIC} PUBLIC .)

set_target_properties(${PROJECT_NAME}static PROPERTIES
set_target_properties(${TARGET_STATIC} PROPERTIES
VERSION ${CMAKE_INDI_VERSION_STRING}
SOVERSION ${INDI_SOVERSION}
OUTPUT_NAME ${PROJECT_NAME} # this same name like shared library - backwards compatibility
)

install(TARGETS ${PROJECT_NAME}static
install(TARGETS ${TARGET_STATIC}
ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}
)
endif()

# Build Shared Library
if(INDI_BUILD_SHARED)
add_library(${PROJECT_NAME} SHARED)

target_link_libraries(${PROJECT_NAME} PUBLIC ${PROJECT_NAME}_OBJECT ${${PROJECT_NAME}_LIBS})
add_library(${TARGET_SHARED} SHARED)

target_include_directories(${PROJECT_NAME} PUBLIC .)
target_link_libraries(${TARGET_SHARED} PUBLIC ${TARGET_OBJECT} ${${PROJECT_NAME}_LIBS})
target_include_directories(${TARGET_SHARED} PUBLIC .)

set_target_properties(${PROJECT_NAME} PROPERTIES
set_target_properties(${TARGET_SHARED} PROPERTIES
VERSION ${CMAKE_INDI_VERSION_STRING}
SOVERSION ${INDI_SOVERSION}
OUTPUT_NAME ${PROJECT_NAME}
)

install(TARGETS ${PROJECT_NAME}
install(TARGETS ${TARGET_SHARED}
LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}
)
endif()
Loading