-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOptron iEAF indi driver #1962
iOptron iEAF indi driver #1962
Conversation
Thank you. You need to add this file to focusers/CMakeLists.txt so that it compiles. Another entry is required in drivers.xml so that the driver is defined in 3rd party clients. |
Thank you, it looks like your created another PR to add the missing files. You need to add this missing files to this PR, not #1965 |
add iOptron iEAF compile entry
add iOptron iEAF driver entry
drivers.xml
Outdated
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove the extra space.
drivers/focuser/ieaffocus.cpp
Outdated
defineProperty(MaxPositionNP); | ||
defineProperty(SetZeroSP); | ||
GetFocusParams(); | ||
loadConfig(true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to call loadConfig(true) explicitly, it will be called by the client.
char errstr[MAXRBUF]; | ||
char resp[16]; | ||
int ieafpos,ieafmodel,ieaflast; | ||
sleep(2); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this really required?
@joe13905179063 Can you please my feedback and update the PR? |
Thanks! I commented unused codes and updated files. |
Thank you! Few minor errors, remove any unused variable. |
thanks your help again . I update latest codes . I compiled iEAF focuser driver on MACOS and OK. |
No description provided.