Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOptron iEAF indi driver #1962

Merged
merged 14 commits into from
Dec 18, 2023
Merged

iOptron iEAF indi driver #1962

merged 14 commits into from
Dec 18, 2023

Conversation

joe13905179063
Copy link
Contributor

No description provided.

@knro
Copy link
Contributor

knro commented Nov 17, 2023

Thank you. You need to add this file to focusers/CMakeLists.txt so that it compiles. Another entry is required in drivers.xml so that the driver is defined in 3rd party clients.

@knro knro self-assigned this Nov 17, 2023
@knro
Copy link
Contributor

knro commented Nov 19, 2023

Thank you, it looks like your created another PR to add the missing files. You need to add this missing files to this PR, not #1965

add iOptron iEAF compile entry
add iOptron iEAF driver entry
@joe13905179063 joe13905179063 mentioned this pull request Nov 20, 2023
drivers/focuser/ieaffocus.h Outdated Show resolved Hide resolved
drivers.xml Outdated
Comment on lines 324 to 325


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the extra space.

drivers/focuser/ieaffocus.cpp Outdated Show resolved Hide resolved
defineProperty(MaxPositionNP);
defineProperty(SetZeroSP);
GetFocusParams();
loadConfig(true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to call loadConfig(true) explicitly, it will be called by the client.

char errstr[MAXRBUF];
char resp[16];
int ieafpos,ieafmodel,ieaflast;
sleep(2);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this really required?

drivers/focuser/ieaffocus.cpp Outdated Show resolved Hide resolved
@knro
Copy link
Contributor

knro commented Dec 13, 2023

@joe13905179063 Can you please my feedback and update the PR?

@joe13905179063
Copy link
Contributor Author

Thanks! I commented unused codes and updated files.

@knro
Copy link
Contributor

knro commented Dec 14, 2023

Thank you! Few minor errors, remove any unused variable.

@joe13905179063
Copy link
Contributor Author

thanks your help again . I update latest codes . I compiled iEAF focuser driver on MACOS and OK.

@knro knro merged commit fdf1b75 into indilib:master Dec 18, 2023
11 checks passed
@joe13905179063 joe13905179063 deleted the patch-1 branch May 29, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants