Option to use system provided httplib #1946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
System provided httplib requires CMake find file as well? |
Oh, yes, I haven't realized httplib provides CMake find file. |
|
Exactly |
mattiaverga
force-pushed
the
unbundle-httplib
branch
from
37bfcf2 to
d1d6d7d
Compare
|
Ok, not much cmake/C knowledge here, but I hope to have done it right... |
knro
reviewed
Oct 2, 2023
Signed-off-by: Mattia Verga <[email protected]>
mattiaverga
force-pushed
the
unbundle-httplib
branch
from
d1d6d7d to
9fcc5bd
Compare
|
@pawel-soja Do you know what is causing the failure? I can reproduce the issue locally, it's related to the %include "indiapi.h" is this a new issue though? |
|
@knro I quickly looked through what was wrong and I think I found it. I've linked a new pull request to this thread. Once it is built, the problem is found and solved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Linux distributions have their own httplib packaged, this will add an option to use the system provided one (default to use bundled library).