More components #47
Merged
More components #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd added an SR latch
default-username-852
added
area-simulation
enhancement
NogginBops
reviewed
May 10, 2020
NogginBops
reviewed
May 10, 2020
NogginBops
reviewed
May 10, 2020
NogginBops
approved these changes
May 10, 2020
Signed-off-by: Eskil Q <[email protected]>
Signed-off-by: Eskil Q <[email protected]>
|
I've changed the code according to the feedback and I've also added test for working out diffs, to make sure it works. |
NilsLofberg
approved these changes
May 12, 2020
|
Ok we have two approving reviews so I'm going to merge this pr now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds all components marked as "Prio 1" in #41. It also removes the
dirty_subnetinterface because it's no longer needed.What remains to be implemented for these components is that some components should be "pokeable" as outlined in #40. There might also be a need for further unit tests and documentation.