Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intégrer “Aucun” dans les mosaïques de réponses [NGC-1239] #747

Draft
wants to merge 7 commits into
base: preprod
Choose a base branch
from

Conversation

florianpanchout
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Oct 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nosgestesclimat ✅ Ready (Inspect) Visit Preview Oct 10, 2024 8:31am

Copy link

Copy link

github-actions bot commented Oct 8, 2024

Report for the pull request #747


🌐 Translation status

UI's texts

Language Nb. missing translations Status
en Ø ✔️
es Ø ✔️

FAQ's questions

Language Nb. missing translations Status
en Ø ✔️
es Ø ✔️

You will find more information about the translation in the dedicated file.

...props
}: Props) {
const aucunOption = suggestions.find((suggestion) =>
aucunLabels.includes(suggestion.label)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better with a Set

@@ -692,13 +692,6 @@
resolved "https://registry.yarnpkg.com/@discoveryjs/json-ext/-/json-ext-0.5.7.tgz#1d572bfbbe14b7704e0ba0f39b74815b84870d70"
integrity sha512-dBVuXR082gk3jsFp7Rd/JI4kytwGHecnCoTtXFb7DB6CNHp4rg5k1bhg0nWdLGLnOV71lmDzGQaLMy8iPLY0pw==

"@emnapi/runtime@^1.2.0":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please freeze lockfile

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any recommandation on how to do that ? Is there something to add to yarmrc.yml ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@bjlaa bjlaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super cool ! Tu as une erreur ts au moment du build. J'ai quelques questions :

  • est-ce qu'il ne faudrait pas ajouter l'option "Aucun" pour cette question ?
Capture d’écran 2024-10-09 à 17 21 27
  • MAIS je trouve ça un peu bizarre d'avoir un input différent des autres de la liste pas toi ?
Capture d’écran 2024-10-09 à 17 22 32 Capture d’écran 2024-10-09 à 17 21 27

@bjlaa
Copy link
Contributor

bjlaa commented Oct 9, 2024

Aussi dernière chose : on a une couleur de texte différente entre les champs checkbox et les autres ici, ce serait peut-être l'occaz de tout harmoniser en utilisant la couleur du texte par défaut partout
Capture d’écran 2024-10-09 à 17 22 32

@florianpanchout
Copy link
Contributor Author

florianpanchout commented Oct 10, 2024

Mis en pause en attendant les UI

@florianpanchout florianpanchout marked this pull request as draft October 10, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants