Améliorer les suggestions [NGC-1191] [NGC-1217] #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Report for the pull request #694🌐 Translation statusUI's texts
FAQ's questions
|
florianpanchout
changed the title
bjlaa
reviewed
Sep 19, 2024
|
|
||
| const handleSuggestionClick = useCallback( | ||
| (suggestion: FormattedSuggestion) => { | ||
| trackEvent( |
There was a problem hiding this comment.
Est-ce qu'il ne faudrait pas modifier ce tracker pour faire en sorte d'y inclure le nombre de fois que la suggestion aura été sélectionnée ?
There was a problem hiding this comment.
Pas sur que ça ait un interêt. L'idée de ce tracking c'est de savoir quelles suggestions sont cliquées. Pour avoir les valeurs moyennes on a d'autres trackers
Co-authored-by: Benjamin Arias <[email protected]>
Co-authored-by: Benjamin Arias <[email protected]>
…t-site-nextjs into NGC-1191
|
Mis en pause en attendant les UI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.