Add option to separate named imports #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses incu6us#116 Add a `-separate-named` boolean option. When activated, named/aliased imports are split off into a separate block below the relevant group, e.g. named std below std, named project below project, etc.
|
@incu6us I've updated this against current upstream/master and fixed the conflict |
ccoVeille
reviewed
Nov 20, 2024
| @@ -84,6 +84,8 @@ Usage of goimports-reviser: | |||
| Apply rules recursively if target is a directory. In case of ./... execution will be recursively applied by default. Optional parameter. | |||
| -rm-unused | |||
| Remove unused imports. Optional parameter. | |||
| -separate-named | |||
| Separate named imports from their group with a new line. Optional parameter. | |||
There was a problem hiding this comment.
I would have reused the "alias" term
Suggested change
| Separate named imports from their group with a new line. Optional parameter. | |
| Separate aliased imports from their group with a new line. Optional parameter. |
| @@ -56,6 +57,7 @@ var ( | |||
| shouldSetAlias *bool | |||
| shouldFormat *bool | |||
| shouldApplyToGeneratedFiles *bool | |||
| shouldSeparateNamedImports *bool | |||
There was a problem hiding this comment.
Suggested change
| shouldSeparateNamedImports *bool | |
| shouldSeparateAliases *bool |
And rename everything
incu6us
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #116
Add a
-separate-namedboolean option. When activated, named/aliased imports are split off into a separate block below the relevant group, e.g. named std below std, named project below project, etc.