Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set-exit-status on recursivePath #157

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: set-exit-status on recursivePath #157

wants to merge 2 commits into from

Conversation

micaelmalta
Copy link

This fixes set-exit-status when using ./...

#93

@micaelmalta micaelmalta force-pushed the fix-set-exit-status branch 4 times, most recently from 6a29e6e to cfb73ee Compare May 27, 2024 16:26
@micaelmalta micaelmalta mentioned this pull request May 27, 2024
Closed
@micaelmalta micaelmalta force-pushed the fix-set-exit-status branch from cfb73ee to 9db37ec Compare May 27, 2024 17:01
@codecov Codecov
Copy link

codecov bot commented May 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 57.75%. Comparing base (38044e6) to head (9db37ec).
Report is 1 commits behind head on master.

❗ Current head 9db37ec differs from pull request most recent head 99288e4

Please upload reports for the commit 99288e4 to get more accurate results.

Files Patch % Lines
reviser/dir.go 0.00% 4 Missing and 2 partials ⚠️
main.go 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           master     #157       +/-   ##
===========================================
- Coverage   89.06%   57.75%   -31.32%     
===========================================
  Files           9       11        +2     
  Lines         686     1058      +372     
===========================================
  Hits          611      611               
- Misses         52      422      +370     
- Partials       23       25        +2
Flag Coverage Δ
unittests 57.75% <0.00%> (-31.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@micaelmalta micaelmalta force-pushed the fix-set-exit-status branch from 9db37ec to 99288e4 Compare May 27, 2024 17:04
ccoVeille
ccoVeille reviewed Sep 9, 2024
View reviewed changes
reviser/dir.go
Comment on lines +124 to +127
if len(badFormattedCollection) == 0 {
return nil, nil
}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TestSourceDir_Find could be updated to check this change

@apostasie
Copy link

apostasie commented Dec 14, 2024 •
edited
Loading

Hey folks.

Curious if this could be moved forward / what is blocking here?

Would love to see this in so we can get rid of our hacks (in https://github.com/containerd/nerdctl/blob/main/hack/lint-imports.sh)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccoVeille ccoVeille ccoVeille left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@micaelmalta @apostasie @ccoVeille @incu6us