Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#144] If it is single import, do not convert into an import list #145

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

Ericwww
Copy link
Contributor

@Ericwww Ericwww commented Dec 11, 2023

To fix #144

Adjust the position to determine whether an empty string Token &ast.ImportSpec{Path: &ast.BasicLit{Value: "", Kind: token.STRING}} needs to be added.

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (194719a) 89.08% compared to head (2902c85) 89.06%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #145      +/-   ##
==========================================
- Coverage   89.08%   89.06%   -0.02%     
==========================================
  Files           9        9              
  Lines         687      686       -1     
==========================================
- Hits          612      611       -1     
  Misses         52       52              
  Partials       23       23              
Flag Coverage Δ
unittests 89.06% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ericwww Ericwww force-pushed the fix-single-import branch 2 times, most recently from 6c22ddd to ef979c4 Compare December 11, 2023 19:56
@Ericwww Ericwww force-pushed the fix-single-import branch from ef979c4 to 7ac25d6 Compare January 6, 2024 10:31
@Ericwww Ericwww force-pushed the fix-single-import branch 2 times, most recently from 3b27b77 to a31f31f Compare January 23, 2024 20:19
@incu6us incu6us merged commit 38044e6 into incu6us:master Jan 24, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Single import becomes a list of imports
2 participants