Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix definition of "coordinate vector" #420

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions doc/content/specs/nidm-results_dev.html
Original file line number Diff line number Diff line change
Expand Up @@ -2188,8 +2188,8 @@ <h1 label="NIDM_0000015">nidm:'Coordinate'</h1>
<div class="attributes" id="attributes-nidm:'Coordinate'"> A <a title="NIDM_0000015">nidm:'Coordinate'</a> has attributes:
<ul>
<li><span class="attribute" id="nidm:'Coordinate'.label">rdfs:label</span>: (<em class="rfc2119" title="OPTIONAL">OPTIONAL</em>) Human readable description of the <a title="NIDM_0000015">nidm:'Coordinate'</a>.</li>
<li><a title="NIDM_0000086"><dfn title="NIDM_0000086">nidm:'coordinate Vector'</dfn></a> <a href="https://github.com/incf-nidash/nidm/issues?&q=is%3Aopen+'nidm:'coordinate Vector''""><sup>&#9734;</sup></a><a href="https://github.com/incf-nidash/nidm/issues/new";"><sup>+</sup></a></span>: (<em class="rfc2119" title="OPTIONAL">OPTIONAL</em>) A vector with one number per dimension. The first element corresponds to the <a title=NIDM_0000015>'Coordinate'</a> along the first dimension measured in map elements (e.g., pixels, voxels, vertices, or faces), the second element to the <a title=NIDM_0000015>'Coordinate'</a> along the second dimension etc. (range <a title="string" href ="http://www.w3.org/2001/XMLSchema#string">xsd:string</a>).</li>
<li><a title="NIDM_0000139"><dfn title="NIDM_0000139">nidm:'coordinate Vector In Voxels'</dfn></a> <a href="https://github.com/incf-nidash/nidm/issues?&q=is%3Aopen+'nidm:'coordinate Vector In Voxels''""><sup>&#9734;</sup></a><a href="https://github.com/incf-nidash/nidm/issues/new";"><sup>+</sup></a></span>: (<em class="rfc2119" title="OPTIONAL">OPTIONAL</em>) Coordinate along the first dimension in voxels. (This definition needs to be re-worked as this term was renamed from coordinate1 to coordinate in https://github.com/incf-nidash/nidm/issues/270). (range <a title="string" href ="http://www.w3.org/2001/XMLSchema#string">xsd:string</a>).</li>
<li><a title="NIDM_0000086"><dfn title="NIDM_0000086">nidm:'coordinate Vector'</dfn></a> <a href="https://github.com/incf-nidash/nidm/issues?&q=is%3Aopen+'nidm:'coordinate Vector''""><sup>&#9734;</sup></a><a href="https://github.com/incf-nidash/nidm/issues/new";"><sup>+</sup></a></span>: (<em class="rfc2119" title="OPTIONAL">OPTIONAL</em>) A vector with one number per dimension. The first element corresponds to the <a title=NIDM_0000015>'Coordinate'</a> along the first dimension measured in world units (e.g. 'mm'), the second element to the <a title=NIDM_0000015>'Coordinate'</a> along the second dimension etc. (range <a title="string" href ="http://www.w3.org/2001/XMLSchema#string">xsd:string</a>).</li>
<li><a title="NIDM_0000139"><dfn title="NIDM_0000139">nidm:'coordinate Vector In Voxels'</dfn></a> <a href="https://github.com/incf-nidash/nidm/issues?&q=is%3Aopen+'nidm:'coordinate Vector In Voxels''""><sup>&#9734;</sup></a><a href="https://github.com/incf-nidash/nidm/issues/new";"><sup>+</sup></a></span>: (<em class="rfc2119" title="OPTIONAL">OPTIONAL</em>) A vector with one number per dimension. The first element corresponds to the <a title=NIDM_0000015>'Coordinate'</a> along the first dimension measured in map elements (e.g., pixels, voxels, vertices, or faces), the second element to the <a title=NIDM_0000015>'Coordinate'</a> along the second dimension etc. (range <a title="string" href ="http://www.w3.org/2001/XMLSchema#string">xsd:string</a>).</li>
</ul>
</div>
</ul>
Expand Down
4 changes: 2 additions & 2 deletions nidm/nidm-results/terms/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ Thank you in advance for taking part in NIDM-Results term curation!
<tr>
<td><img src="../../../doc/content/specs/img/green.png?raw=true"/> </td>
<td>Under discussion at: <a href="https://github.com/incf-nidash/nidm/pull/270">#270</a> and <a href="https://github.com/incf-nidash/nidm/pull/145">#145</a><br/><a href="https://github.com/incf-nidash/nidm//issues?&q='coordinate Vector'"> [more] </a></td>
<td><b>nidm:'coordinate Vector': </b>A vector with one number per dimension. The first element corresponds to the <a title=NIDM_0000015>'Coordinate'</a> along the first dimension measured in map elements (e.g., pixels, voxels, vertices, or faces), the second element to the <a title=NIDM_0000015>'Coordinate'</a> along the second dimension etc</td>
<td><b>nidm:'coordinate Vector': </b>A vector with one number per dimension. The first element corresponds to the <a title=NIDM_0000015>'Coordinate'</a> along the first dimension measured in world units (e.g. 'mm'), the second element to the <a title=NIDM_0000015>'Coordinate'</a> along the second dimension etc</td>
<td>nidm:NIDM_0000015 </td>
<td>xsd:string </td>
</tr>
Expand Down Expand Up @@ -219,7 +219,7 @@ Thank you in advance for taking part in NIDM-Results term curation!
<tr>
<td><img src="../../../doc/content/specs/img/orange.png?raw=true"/> </td>
<td>Under discussion at: <a href="https://github.com/incf-nidash/nidm/pull/270">#270</a><br/><a href="https://github.com/incf-nidash/nidm//issues?&q='coordinate Vector In Voxels'"> [more] </a></td>
<td><b>nidm:'coordinate Vector In Voxels': </b>Coordinate along the first dimension in voxels. (This definition needs to be re-worked as this term was renamed from coordinate1 to coordinate in https://github.com/incf-nidash/nidm/issues/270)</td>
<td><b>nidm:'coordinate Vector In Voxels': </b>A vector with one number per dimension. The first element corresponds to the <a title=NIDM_0000015>'Coordinate'</a> along the first dimension measured in map elements (e.g., pixels, voxels, vertices, or faces), the second element to the <a title=NIDM_0000015>'Coordinate'</a> along the second dimension etc</td>
<td>nidm:NIDM_0000015 </td>
<td>xsd:string </td>
</tr>
Expand Down
4 changes: 2 additions & 2 deletions nidm/nidm-results/terms/nidm-results.owl
Original file line number Diff line number Diff line change
Expand Up @@ -576,7 +576,7 @@ nidm:NIDM_0000086 rdf:type owl:DatatypeProperty ;

obo:IAO_0000112 "[-60, 32, 54]"^^xsd:string ;

obo:IAO_0000115 "A vector with one number per dimension. The first element corresponds to the 'Coordinate' along the first dimension measured in map elements (e.g., pixels, voxels, vertices, or faces), the second element to the 'Coordinate' along the second dimension etc." ;
obo:IAO_0000115 "A vector with one number per dimension. The first element corresponds to the 'Coordinate' along the first dimension measured in world units (e.g. 'mm'), the second element to the 'Coordinate' along the second dimension etc." ;

obo:IAO_0000116 "Under discussion at: https://github.com/incf-nidash/nidm/pull/270 and https://github.com/incf-nidash/nidm/issues/145" ;

Expand Down Expand Up @@ -1233,7 +1233,7 @@ nidm:NIDM_0000139 rdf:type owl:DatatypeProperty ;

rdfs:label "coordinate Vector In Voxels" ;

obo:IAO_0000115 "Coordinate along the first dimension in voxels. (This definition needs to be re-worked as this term was renamed from coordinate1 to coordinate in https://github.com/incf-nidash/nidm/issues/270)" ;
obo:IAO_0000115 "A vector with one number per dimension. The first element corresponds to the 'Coordinate' along the first dimension measured in map elements (e.g., pixels, voxels, vertices, or faces), the second element to the 'Coordinate' along the second dimension etc." ;

obo:IAO_0000112 "[12 51 48]" ;

Expand Down