Storage permissions dependent on Android SDK version

inaturalist · Sep 6, 2023 · d8f5fdf · d8f5fdf
1 parent 7b013ce
commit d8f5fdf
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 5 deletions.
diff --git a/iNaturalist/src/main/AndroidManifest.xml b/iNaturalist/src/main/AndroidManifest.xml
@@ -3,8 +3,8 @@
     xmlns:tools="http://schemas.android.com/tools"
     package="org.inaturalist.android"
     android:installLocation="auto"
-    android:versionCode="584"
-    android:versionName="1.29.10">
+    android:versionCode="585"
+    android:versionName="1.29.11">
 
     <uses-permission android:name="android.permission.INTERNET" />
     <uses-permission android:name="android.permission.ACCESS_FINE_LOCATION" />
@@ -19,6 +19,7 @@
     <uses-permission android:name="android.permission.FOREGROUND_SERVICE" />
     <uses-permission android:name="android.permission.READ_MEDIA_IMAGES" />
     <uses-permission android:name="android.permission.READ_MEDIA_AUDIO" />
+    <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" />
 
     <uses-feature android:name="android.hardware.location.gps" />
 

diff --git a/iNaturalist/src/main/java/org/inaturalist/android/INaturalistApp.java b/iNaturalist/src/main/java/org/inaturalist/android/INaturalistApp.java
@@ -1283,14 +1283,20 @@ public void requestAccessMediaLocationPermission(Activity activity, OnRequestPer
     }
 
     public void requestExternalStoragePermission(Activity activity, OnRequestPermissionResult cb) {
-        requestPermissions(activity, new String[] { Manifest.permission.WRITE_EXTERNAL_STORAGE }, cb);
+        if (android.os.Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU) {
+            requestPermissions(activity, new String[]{Manifest.permission.READ_MEDIA_IMAGES, Manifest.permission.READ_MEDIA_AUDIO}, cb);
+        } else {
+            requestPermissions(activity, new String[]{Manifest.permission.READ_EXTERNAL_STORAGE}, cb);
+        }
     }
 
     public void requestAudioRecordingPermission(Activity activity, OnRequestPermissionResult cb) {
         requestPermissions(activity, new String[] { Manifest.permission.RECORD_AUDIO }, cb);
     }
 
     private void requestPermissions(final Activity activity, final String[] permissions, OnRequestPermissionResult cb) {
+        mPermissionsCbByPermissionName.clear();
+
         for (String permission: permissions) {
             mPermissionsCbByPermissionName.put(permission, cb);
             mPrefs.edit().putBoolean(permission, true).commit();
@@ -1332,6 +1338,8 @@ public void onRequestPermissionsResult(int requestCode, String[] permissions, in
                 } else {
                     cb.onPermissionDenied();
                 }
+
+                break;
             }
         }
     }
@@ -1361,9 +1369,16 @@ public boolean isPermissionPermanentlyDenied(Activity activity, String permissio
     }
 
     public boolean isExternalStoragePermissionGranted() {
-        return (
-                PermissionChecker.checkSelfPermission(this, Manifest.permission.WRITE_EXTERNAL_STORAGE) == PermissionChecker.PERMISSION_GRANTED
+        if (android.os.Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU) {
+            return (
+                    PermissionChecker.checkSelfPermission(this, Manifest.permission.READ_MEDIA_IMAGES) == PermissionChecker.PERMISSION_GRANTED &&
+                            PermissionChecker.checkSelfPermission(this, Manifest.permission.READ_MEDIA_AUDIO) == PermissionChecker.PERMISSION_GRANTED
+            );
+        } else {
+            return (
+                    PermissionChecker.checkSelfPermission(this, Manifest.permission.READ_EXTERNAL_STORAGE) == PermissionChecker.PERMISSION_GRANTED
             );
+        }
     }
 
     public boolean isAudioRecordingPermissionGranted() {